Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting resources from prebuilt framework #84

Merged
merged 4 commits into from
Feb 9, 2021
Merged

Fix getting resources from prebuilt framework #84

merged 4 commits into from
Feb 9, 2021

Conversation

timbaev
Copy link
Contributor

@timbaev timbaev commented Feb 8, 2021

The problem

When install Mantis from Carthage, resources with localization files will not be copy to builded framework.
With CocoaPods everything work well, becouse CocoaPods authomatically generate Bundle with resources indicated in podspec file.

The solution

Create Bundle for resources the same as CocoaPods, put localizable resources into Bundle and link with Mantis target.
After this, Mantis framework will building with resources from new Bundle.

Copy link
Owner

@guoyingtao guoyingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@guoyingtao guoyingtao merged commit 7399e7f into guoyingtao:master Feb 9, 2021
@timbaev timbaev deleted the fix/resources branch February 9, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants